fix(list): disableRipple on selection list not affecting list options after init #14858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Jan 17, 2019
devversion
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
list-disable-ripple-propagation
branch
from
6e261d4 to
985e740
Compare
Member
|
@crisbeto could you rebase this? |
… after init Along the same lines as angular#14836. Fixes changes to `disableRipple` not being propagated immediately the list options.
crisbeto
force-pushed
the
list-disable-ripple-propagation
branch
from
985e740 to
48a56ee
Compare
Member
Author
|
Rebased. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the same lines as #14836. Fixes changes to
disableRipplenot being propagated immediately the list options.