chore: add autoprefixer to gulp #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Oct 14, 2016
•
devversion
commented
- At the time of moving to gulp, the autoprefixer has been removed from the project.
- Re-introducing the autoprefixer for the "latest two versions" as in the README stated, does make sure that all CSS properties are working within the supported browsers.
* At the time of moving to gulp, the autoprefixer is no longer running against the CSS. * Re-introducing the autoprefixer for the "latest two versions" as in the README stated, does make sure that each properties are working within the supported browsers.
googlebot
added
the
cla: yes
jelbourn
reviewed
Oct 17, 2016
| export const SASS_AUTOPREFIXER_OPTIONS = { | ||
| browsers: ['last 2 versions'], | ||
| cascade: false, | ||
| }; |
There was a problem hiding this comment.
If I recall correctly, we need to explicitly exclude IE10 and mobile IE because autoprefixer considers "IE" and "Edge" to be separate browsers, thus IE10 falls within the last two versions. This is necessary to prevent it from adding the outdated ms-flex prefixed rules.
There was a problem hiding this comment.
I see. Just took a look at https://github.com/ai/browserslist and you're right.
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.