doc(dialog): document MdDialog #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Oct 24, 2016
| | Key | Description | | ||
| | --- | --- | | ||
| | `viewContainerRef: ViewContainerRef` | The view container ref to attach the dialog to. | | ||
| | `role: DialogRole = 'dialog'` | The ARIA role of the dialog element. Possible values are `dialog` and `alertdialog`. | |
There was a problem hiding this comment.
Also mention "Defaults to 'dialog'"
| } | ||
|
|
||
| @Component({ | ||
| selector: 'my-dialog', |
There was a problem hiding this comment.
I like to use example components names that are super obviously examples (which is why there are so many PizzaComponents in the source). This avoid the problem of people seeing this selector and thinking it's a magic identifier that you must use.
Can you change MyDialog and MyComponent to be something else?
|
LGTM, thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily based on the snack-bar doc. Comments are welcome.
Refs #1566