Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/stepper): allow for content to be rendered lazily #15817

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

crisbeto
Copy link
Member

Adds the matStepContent directive that allows consumers to defer rendering the content of a step until it is opened for the first time.

Fixes #12339.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Apr 14, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 14, 2019
@crisbeto crisbeto force-pushed the 12339/stepper-lazy-content branch from c6084ee to f46c948 Compare April 14, 2019 11:03
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@crisbeto crisbeto force-pushed the 12339/stepper-lazy-content branch from f46c948 to c53ac6e Compare April 29, 2019 20:12
@andrewseguin andrewseguin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 30, 2019
@crisbeto crisbeto force-pushed the 12339/stepper-lazy-content branch from c53ac6e to 9ac9a24 Compare August 4, 2019 17:47
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/material/stepper/stepper.md Show resolved Hide resolved
@princemaple
Copy link
Contributor

Will this go in at some point?

@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@mmalerba
Copy link
Contributor

mmalerba commented Nov 5, 2020

@crisbeto looks like this needs to be rebased

@crisbeto crisbeto force-pushed the 12339/stepper-lazy-content branch from 9ac9a24 to fff352a Compare November 6, 2020 05:35
@crisbeto crisbeto changed the title feat(stepper): allow for content to be rendered lazily feat(material/stepper): allow for content to be rendered lazily Nov 6, 2020
@crisbeto crisbeto force-pushed the 12339/stepper-lazy-content branch from fff352a to 7eb1666 Compare November 6, 2020 05:44
@crisbeto
Copy link
Member Author

crisbeto commented Nov 6, 2020

Rebased. Also had to make some code changes to get everything working with a few changes from master.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2020
@princemaple
Copy link
Contributor

princemaple commented Jan 15, 2021

Please don't miss this one for 11.1, 🙏 thanks!

Adds the `matStepContent` directive that allows consumers to defer rendering
the content of a step until it is opened for the first time.

Fixes angular#12339.
@crisbeto crisbeto force-pushed the 12339/stepper-lazy-content branch from 7eb1666 to f4023c8 Compare January 15, 2021 09:31
@princemaple
Copy link
Contributor

Maybe 11.2 then...

@annieyw annieyw merged commit 52f39bc into angular:master Feb 7, 2021
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…lar#15817)

Adds the `matStepContent` directive that allows consumers to defer rendering
the content of a step until it is opened for the first time.

Fixes angular#12339.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MatStepContent directive just like MatTabContent directive for lazy loading step content
7 participants