feature(checkbox): Add ripple effect to checkbox #1611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Oct 26, 2016
src/lib/checkbox/checkbox.spec.ts
Outdated
| fixture.detectChanges(); | ||
|
|
||
| expect(checkboxNativeElement.querySelectorAll('[md-ripple]').length).toBe(0, | ||
| 'Expect no [md-ripple] in checkbox'); |
There was a problem hiding this comment.
In general, prefer to break at the higher syntactic level, e.g.:
expect(checkboxNativeElement.querySelectorAll('[md-ripple]').length)
.toBe(0, 'Expect no [md-ripple] in checkbox');
src/lib/checkbox/checkbox.ts
Outdated
|
|
||
| isRippleEnabled() { | ||
| return !this.disableRipple; | ||
| } |
There was a problem hiding this comment.
Why not bind to the disableRipple directly?
src/lib/checkbox/checkbox.ts
Outdated
| @Input() id: string = `md-checkbox-${++nextId}`; | ||
|
|
||
| /** Whether the ripple effect on click should be disabled. */ | ||
| @Input() @BooleanFieldValue() disableRipple: boolean = false; |
There was a problem hiding this comment.
I just removed @BooleanFieldValue in another PR- custom decorators like this caused tree-shaking not to work. The replacement is a function called coerceBooleanProperty
tinayuangao
force-pushed
the
ripple-checkbox
branch
from
01a8190 to
d490bc2
Compare
tinayuangao
force-pushed
the
ripple-checkbox
branch
from
d490bc2 to
2ef7562
Compare
|
Comments addressed. Please take another look. Thanks! |
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jelbourn