Skip to content

refactor(version): Create version subpackages #16296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(version): Create version subpackages #16296

wants to merge 1 commit into from

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Jun 14, 2019

No description provided.

@josephperrott josephperrott added the target: minor This PR is targeted for the next minor release label Jun 14, 2019
@josephperrott josephperrott requested a review from jelbourn as a code owner June 14, 2019 16:20
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 14, 2019
@josephperrott josephperrott force-pushed the version-packages branch 3 times, most recently from a96526f to cf7c0a7 Compare June 14, 2019 16:37
@josephperrott josephperrott added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 14, 2019
@josephperrott
Copy link
Member Author

josephperrott commented Jun 14, 2019

Caretaker:
This PR will require creating internal BUILD rules and removing the transform created in cl/251715451

jelbourn
jelbourn approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we'll need a schematic for this in another PR.

@josephperrott josephperrott added this to the 8.1.0 milestone Jun 14, 2019
@josephperrott
refactor(version): Create version subpackage for @angular/material, @…
51a6da9 
…angular/cdk, @angular/cdk-experimental and @angular/material-experimental
devversion
devversion approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agreed that we need a migration schematic for this one. will someone create a JIRA ticket for this?

@jelbourn
Copy link
Member

jelbourn commented Jun 17, 2019

@devversion did we ever add a block for deprecation to the changelog?

@devversion
Copy link
Member

devversion commented Jun 17, 2019

@jelbourn I think we only created these manually. Did you think about doing this automatically?

@jelbourn
Copy link
Member

jelbourn commented Jun 17, 2019

Captured in #16307

@Splaktar Splaktar modified the milestones: 8.1.0, 8.2.0 Nov 14, 2019
@josephperrott josephperrott deleted the version-packages branch March 20, 2020 22:16
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 20, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

8.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@josephperrott @jelbourn @devversion @Splaktar @googlebot