Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material-experimental/checkbox): Add test harnesses for both versions of mat-checkbox #16334

Merged
merged 8 commits into from
Jun 21, 2019
Merged

feat(material-experimental/checkbox): Add test harnesses for both versions of mat-checkbox #16334

merged 8 commits into from
Jun 21, 2019

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba requested review from jelbourn and crisbeto June 19, 2019 21:10
@mmalerba mmalerba requested a review from devversion as a code owner June 19, 2019 21:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 19, 2019
crisbeto
crisbeto approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/cdk-experimental/testing/protractor/protractor-element.ts Show resolved Hide resolved
@mmalerba mmalerba added pr: merge safe target: patch This PR is targeted for the next patch release labels Jun 20, 2019
jelbourn
jelbourn approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 21, 2019
@jelbourn jelbourn merged commit 7398c9a into angular:master Jun 21, 2019
andrewseguin pushed a commit that referenced this pull request Jul 2, 2019
@mmalerba @andrewseguin
feat(material-experimental/checkbox): Add test harnesses for both ve…
1f303ab 
…rsions of mat-checkbox (#16334)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @crisbeto @googlebot