Skip to content

Conversation

@jelbourn
Copy link
Member

@jelbourn jelbourn commented Jul 2, 2019

Fixes #16419

@jelbourn jelbourn added docs This issue is related to documentation pr: merge safe target: patch This PR is targeted for the next patch release labels Jul 2, 2019
@jelbourn jelbourn requested a review from andrewseguin July 2, 2019 22:00
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 2, 2019
@andrewseguin
Copy link
Contributor

LGTM - though it'd be nice to include any exciting features we want to support, even small ones

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2019
@ngbot
Copy link

ngbot bot commented Jul 9, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit fe26614 into angular:master Jul 10, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roadmap Q3 2019

3 participants