fix(slide-toggle): invalid required validator in template-driven forms #16547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
target: patch
googlebot
added
the
cla: yes
crisbeto
reviewed
Jul 17, 2019
Currently using the `slide-toggle` in a form using template-driven forms causes the slide-toggle to retrieve a wrong validator if the `required` attribute is set. This is because by default `@angular/forms` uses an input validator that ensures that the value is just defined. This is always the case for a slide-toggle since the value is always `true` or `false`. The solution to this problem is that we need to provide the checkbox validator for required slide-toggle components. The checkbox validator from the forms package ensures that the control is only valid if the slide-toggle is checked.
devversion
force-pushed
the
fix/slide-toggle-required-validator-template-forms
branch
from
f6a5fd9 to
60a2cdf
Compare
jelbourn
added
pr: lgtm
action: merge
Member
|
Going with |
andrewseguin
pushed a commit
that referenced
this pull request
Jul 29, 2019
#16547) Currently using the `slide-toggle` in a form using template-driven forms causes the slide-toggle to retrieve a wrong validator if the `required` attribute is set. This is because by default `@angular/forms` uses an input validator that ensures that the value is just defined. This is always the case for a slide-toggle since the value is always `true` or `false`. The solution to this problem is that we need to provide the checkbox validator for required slide-toggle components. The checkbox validator from the forms package ensures that the control is only valid if the slide-toggle is checked.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using the
slide-togglein a form using template-driven forms causesthe slide-toggle to retrieve a wrong validator if the
requiredattribute is set.This is because by default
@angular/formsuses an input validatorthat ensures that the value is just defined. This is always the case for
a slide-toggle since the value is always
trueorfalse.The solution to this problem is that we need to provide the checkbox validator
for required slide-toggle components. The checkbox validator from the forms
package ensures that the control is only valid if the slide-toggle is checked.