docs(Getting Started): Updated material Getting Started guide to use install schematics and simplify the overall process #16654
+51
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
googlebot
added
the
cla: no
manughub
force-pushed
the
master
branch
2 times, most recently
from
86041ab to
0963296
Compare
This comment has been minimized.
This comment has been minimized.
googlebot
added
cla: yes
jelbourn
reviewed
Aug 1, 2019
jelbourn
added
docs
|
The failing It looks like I don't have permission to re-run the workflow, but that should hopefully resolve itself after your next push. |
|
We should add a section to address these issues |
|
All review comments addressed. |
Splaktar
previously requested changes
Aug 10, 2019
| ``` | ||
|
|
||
| Alternatively, you can create a separate NgModule that imports and then re-exports all of the Angular Material components that you will use in your application. By exporting them again, other modules can simply include your `CustomMaterialModule` wherever Material components are needed, and automatically get all of the exported Material modules. A good place for importing/exporting the application-wide Material modules is the [SharedModule](https://angular.io/guide/ngmodule-faq#sharedmodule). | ||
| You need to import the `MatSliderModule` that you want to display by adding the following lines to your app.module.ts file. |
There was a problem hiding this comment.
I think that it may be a better getting started experience for new users if they generated a nav via the nav schematic (ng g @angular/material:nav nav).
They would only need one additional step to replace their app.component.html with the <app-nav></app-nav> component after they created it.
There was a problem hiding this comment.
I discussed this with Jeremy and we decided to go with the MatSlider as the nav looks a bit out of place on the demo page. I'm back in the office and will address the other comments and submit my changes.
Splaktar
added
the
P2
|
FYI Manu's OOO this week |
|
Review comments addressed. |
jelbourn
reviewed
Aug 22, 2019
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Aug 26, 2019
…install schematics and simplify the overall process (#16654) * docs: rewrite getting started guide to use CLI schematics * docs(Getting Started): Moving HammerJS install to appendix * docs(Getting Started): Moving HammerJS install to appendix * docs(Getting Started): Moving HammerJS install to appendix (cherry picked from commit ca7fff5)
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Aug 27, 2019
…install schematics and simplify the overall process (angular#16654) * docs: rewrite getting started guide to use CLI schematics * docs(Getting Started): Moving HammerJS install to appendix * docs(Getting Started): Moving HammerJS install to appendix * docs(Getting Started): Moving HammerJS install to appendix
Splaktar
added a commit
that referenced
this pull request
Sep 16, 2019
improvements to header hierarchy and auto-generated anchors - new anchor `/guide/getting-started#step-1` - old anchor `/guide/getting-started#step-1-install-angular-material-npm-packages` add link to hammerjs appendix entry builds upon changes in PR #16654
Splaktar
added a commit
that referenced
this pull request
Sep 16, 2019
improvements to header hierarchy and auto-generated anchors - new anchor `/guide/getting-started#step-1` - old anchor `/guide/getting-started#step-1-install-angular-material-npm-packages` add link to hammerjs appendix entry builds upon changes in PR #16654
Splaktar
added a commit
that referenced
this pull request
Sep 16, 2019
improvements to header hierarchy and auto-generated anchors - new anchor `/guide/getting-started#step-1` - old anchor `/guide/getting-started#step-1-install-angular-material-npm-packages` add link to hammerjs appendix entry builds upon changes in PR #16654
jelbourn
pushed a commit
that referenced
this pull request
Sep 16, 2019
improvements to header hierarchy and auto-generated anchors - new anchor `/guide/getting-started#step-1` - old anchor `/guide/getting-started#step-1-install-angular-material-npm-packages` add link to hammerjs appendix entry builds upon changes in PR #16654
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16426 (Rewrite getting started guide)