Skip to content

fix(stepper): remove tabindex from content #16809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmalerba merged 1 commit into from
Aug 6, 2020
Merged

fix(stepper): remove tabindex from content #16809

mmalerba merged 1 commit into from
Aug 6, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 18, 2019 •
edited
Loading

A while ago in #14892 we added a tabindex to the content of the current step based on a recommendation from W3C a11y guidelines, however since then we consulted with the a11y team and it looks like adding the tabindex there isn't the best approach.

Fixes #16692.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Aug 18, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner August 18, 2019 19:22
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 18, 2019
jelbourn
jelbourn approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 19, 2019
@crisbeto crisbeto force-pushed the 16692/stepper-content-tabindex branch from bfa4022 to 576f8bf Compare September 29, 2019 15:22
@crisbeto crisbeto force-pushed the 16692/stepper-content-tabindex branch from 576f8bf to cbbd31f Compare October 26, 2019 15:19
@crisbeto crisbeto force-pushed the 16692/stepper-content-tabindex branch from cbbd31f to a8e6cf8 Compare January 26, 2020 15:43
@crisbeto crisbeto force-pushed the 16692/stepper-content-tabindex branch from a8e6cf8 to ac4203d Compare February 18, 2020 21:41
@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Feb 19, 2020
@mmalerba
Copy link
Contributor

mmalerba commented Feb 19, 2020

looks like there's some test failures

@crisbeto
fix(stepper): remove tabindex from content
248c651 
A while ago in angular#14892 we added a `tabindex` to the content of the current step, however since then we consulted with the a11y team and it looks like adding the `tabindex` there isn't the best approach.

Fixes angular#16692.
@crisbeto crisbeto force-pushed the 16692/stepper-content-tabindex branch from ac4203d to 248c651 Compare February 20, 2020 06:26
@crisbeto
Copy link
Member Author

crisbeto commented Feb 20, 2020

I've fixed the test failures.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 20, 2020
@crisbeto crisbeto mentioned this pull request Jun 12, 2020
Closed
@NothingEverHappens
Copy link
Contributor

NothingEverHappens commented Jul 23, 2020

Would be awesome to see it merged

@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jul 27, 2020
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@mmalerba mmalerba merged commit df7156e into angular:master Aug 6, 2020
mmalerba pushed a commit that referenced this pull request Aug 6, 2020
@crisbeto @mmalerba
fix(stepper): remove tabindex from content (#16809)
237a6cc 
A while ago in #14892 we added a `tabindex` to the content of the current step, however since then we consulted with the a11y team and it looks like adding the `tabindex` there isn't the best approach.

Fixes #16692.

(cherry picked from commit df7156e)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sdk Stepper tabindex and Web Accessibility Initiative (WAI) compatibility

5 participants

@crisbeto @mmalerba @NothingEverHappens @jelbourn @googlebot