-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: create custom bazel dev-server rule #16937
build: create custom bazel dev-server rule #16937
Conversation
216c660
to
689ace1
Compare
Test failures are caused by a merge conflict in master that will be solved in #16928. |
689ace1
to
313346c
Compare
Implements a custom bazel dev-server rule that can be exposed eventually. The reason we need a custom dev-server implementation is that the "ts_devserver" is not flexible and needs to be synced into google3 (causing slow syncing; and hestitancy to adding new features. always the question of scope). We need our own implemenation because we want: * Live-reloading to work (bazel-contrib/rules_nodejs#1036) * HTML History API support (currently the ts_devserver always sends a 404 status code) * Better host binding of the server (so that we can access the server on other devices) * Flexibility & control (being able to do changes so that the dev-server fits our needs)
313346c
to
00ce81b
Compare
@jelbourn @josephperrott Addressed feedback. Please have another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Implements a custom bazel dev-server rule that can be exposed eventually. The reason
we need a custom dev-server implementation is that the "ts_devserver" is not flexible
and needs to be synced into google3 (causing slow PR turnaround; and hestitancy to adding
new features. always the question of scope: for example)).
We need our own implemenation because we want:
Note: we can talk about exposing this to the public, but that's something we can do afterwards too. Also once this lands, we can use it for the
e2e-app
as well.This also makes #16935 unnecessary as the root-cause is fixed.