feat(cdk/drag-drop): expose native event objects in custom events #17077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
drag-drop-native-events
branch
from
778e182 to
7b3c5bd
Compare
crisbeto
commented
Sep 13, 2019
src/cdk/drag-drop/drop-list-ref.ts
Outdated
| @@ -335,9 +336,11 @@ export class DropListRef<T = any> { | |||
| * container when the item was dropped. | |||
| * @param distance Distance the user has dragged since the start of the dragging sequence. | |||
| * @breaking-change 9.0.0 `distance` parameter to become required. | |||
| * 10.0.0 `event` parameter to become required. | |||
There was a problem hiding this comment.
Note that this looks a little weird, but dgeni was throwing if I add it into a separate @breaking-change.
crisbeto
force-pushed
the
drag-drop-native-events
branch
from
7b3c5bd to
f639659
Compare
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
drag-drop-native-events
branch
from
f639659 to
74e42b2
Compare
crisbeto
force-pushed
the
drag-drop-native-events
branch
from
74e42b2 to
a421c9f
Compare
crisbeto
force-pushed
the
drag-drop-native-events
branch
from
a421c9f to
b451814
Compare
crisbeto
force-pushed
the
drag-drop-native-events
branch
from
b451814 to
461a7b3
Compare
crisbeto
force-pushed
the
drag-drop-native-events
branch
from
461a7b3 to
62cab55
Compare
andrewseguin
added
needs rebase
and removed
cla: yes
crisbeto
changed the title
Exposes the native `MouseEvent` and `TouchEvent` objects in the various drag&drop events since they can contain useful information like which keys were pressed while dragging. Fixes angular#17032.
crisbeto
force-pushed
the
drag-drop-native-events
branch
from
62cab55 to
78d6daf
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the native
MouseEventandTouchEventobjects in the various drag&drop events since they can contain useful information like which keys were pressed while dragging.Fixes #17032.