Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/schematics): support stricter TypeScript compiler flags #17159

Merged
merged 1 commit into from
Sep 23, 2019
Merged

fix(material/schematics): support stricter TypeScript compiler flags #17159

merged 1 commit into from
Sep 23, 2019

Conversation

Splaktar
Copy link
Member

Fixes #17135

@Splaktar Splaktar added P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release labels Sep 20, 2019
@Splaktar Splaktar self-assigned this Sep 20, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 20, 2019
@Splaktar Splaktar force-pushed the schematics-supportStrictCompilerFlags branch from fb3a473 to c3f2425 Compare September 20, 2019 23:43
devversion
devversion approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @crisbeto's comment is addressed.

@Splaktar Splaktar force-pushed the schematics-supportStrictCompilerFlags branch from c3f2425 to 9ea1c2d Compare September 21, 2019 13:18
crisbeto
crisbeto approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 21, 2019
@jelbourn jelbourn merged commit f32fb68 into master Sep 23, 2019
@Splaktar Splaktar deleted the schematics-supportStrictCompilerFlags branch September 23, 2019 23:29
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@Splaktar Splaktar

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schematics: verify that generated code passes CLI's stricter compiler flags
5 participants
@Splaktar @jelbourn @crisbeto @devversion @googlebot