Skip to content

fix(material-experimental/mdc-tabs): error during server-side rendering #17169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2019
Merged

fix(material-experimental/mdc-tabs): error during server-side rendering #17169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/material-experimental/mdc-tabs/ink-bar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ export class MatInkBarFoundation {
this._indicatorContent.style.setProperty(propName, value);
},
computeContentClientRect: () => {
return this._destroyed ? {
// `getBoundingClientRect` isn't available on the server.
return this._destroyed || !this._indicatorContent.getBoundingClientRect ? {
width: 0, height: 0, top: 0, left: 0, right: 0, bottom: 0
} : this._indicatorContent.getBoundingClientRect();
}
Expand Down
23 changes: 23 additions & 0 deletions src/universal-app/kitchen-sink-mdc/kitchen-sink-mdc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,26 @@ <h2>Slider</h2>
<mat-slider value="50"></mat-slider>
<mat-slider tickInterval="1" min="1" max="10" value="5" thumbLabel></mat-slider>
<mat-slider disabled></mat-slider>

<h2>Tabs</h2>

<!--
Note that we set the `selectedIndex` here to hit the code path
where we might need to do some measurements.
-->
<mat-tab-group [selectedIndex]="1">
<mat-tab label="Overview">
The overview
</mat-tab>
<mat-tab>
<ng-template mat-tab-label>
API docs
</ng-template>
The API docs
</mat-tab>
</mat-tab-group>

<nav mat-tab-nav-bar>
<a mat-tab-link href="https://google.com">Google</a>
<a mat-tab-link href="https://google.com" active>Also Google</a>
</nav>