fix(checkbox): missing focus indicator #1730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
cla: yes
crisbeto
force-pushed
the
421/checkbox-focus-ripples
branch
from
7235586 to
8210f09
Compare
jelbourn
reviewed
Nov 8, 2016
| @@ -69,7 +69,7 @@ export class MdCheckboxChange { | |||
| '[class.md-checkbox-checked]': 'checked', | |||
| '[class.md-checkbox-disabled]': 'disabled', | |||
| '[class.md-checkbox-align-end]': 'align == "end"', | |||
| '[class.md-checkbox-focused]': 'hasFocus', | |||
| '[class.md-ripple-focused]': 'hasFocus', | |||
There was a problem hiding this comment.
Can you add a TODO to only show the focus style when it was caused by keyboard?
There was a problem hiding this comment.
Had forgotten about this one. I've added that TODO.
crisbeto
force-pushed
the
421/checkbox-focus-ripples
branch
2 times, most recently
from
6ab3016 to
82a9d3e
Compare
|
Just pulled this down to try it out. If I tab between checkboxes quickly, there's a trail of fading focus indicators left in my wake. |
|
It's the same issue as the one I mentioned here. |
Adds a ripple when a checkbox is focused. Referencing angular#421.
crisbeto
force-pushed
the
421/checkbox-focus-ripples
branch
from
82a9d3e to
c4712de
Compare
|
Please rebase |
|
Closing and will re-do based on the current APIs. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a ripple when a checkbox is focused.
Referencing #421.