docs(dialog): add new option and update example #1814
Conversation
googlebot
added
the
cla: yes
| @@ -12,8 +12,8 @@ MdDialog is a service, which opens dialogs components in the view. | |||
|
|
|||
| | Key | Description | | |||
| | --- | --- | | |||
| | `viewContainerRef: ViewContainerRef` | The view container ref to attach the dialog to. | | |||
There was a problem hiding this comment.
We shouldn't remove this because it is still an option, but it is optional.
|
|
||
| this.dialogRef = this.dialog.open(PizzaDialog, config); | ||
| this.dialogRef = this.dialog.open(PizzaDialog, { | ||
| role: 'alertdialog' |
There was a problem hiding this comment.
This shouldn't be alertdialog since that's not appropriate to the content being opened.
There was a problem hiding this comment.
What I was going for was to show that you can pass in an object, but I didn't want people copying the config over with something like disableClose: true. Having disableClose: false seemed redundant.
* Mentions the `disableClose` option in the readme. * Updates the dialog readme and dialog demo not to use the `viewContainerRef` since it's not necessary anymore.
crisbeto
force-pushed
the
dialog-docs
branch
from
7916f34
to
1999a51
Compare
|
Re-added the |
jelbourn
added
pr: lgtm
action: merge
|
LGTM |
|
some bug when dbclick around dialog |
|
There should be a fix for this one in master @vasyliv. I could reproduce this in the Plunkr, but not locally. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
disableCloseoption in the readme.viewContainerRefsince it's not necessary anymore.