Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(keyboard-event): Replace keycode for keyboard events with key #18264

Closed
wants to merge 4 commits into from
Closed

Refactor(keyboard-event): Replace keycode for keyboard events with key #18264

wants to merge 4 commits into from

Conversation

RudarDaman
Copy link
Contributor

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jan 23, 2020
@crisbeto
Copy link
Member

There are a few reasons why we haven't done this already ourselves and which will make these changes difficult to land:

  1. It wasn't supported on all browsers that we support. I think this might not be an issue anymore.
  2. It's a breaking change for anybody consuming the keycodes package.
  3. From what I remember browsers aren't consistent between each other when it comes to the values that they return for key. E.g. most browsers return ArrowDown whereas IE and Edge return Down.

@jelbourn
Copy link
Member

As outlined in our contributing guide, the first step in working on a large change like this is to open an issue for discussion. Going from there, we always start with a design document and design review with the team. We go through these steps to ensure that everything in the library meets our standards for accessibility, i18n, and consistency with the rest of the code-base.

For this particular issue, we've intentionally not made this change due to browser support concerns. See #7374

@jelbourn jelbourn closed this Jan 24, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants