Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete import that was missed in #18274 #18334

Merged
merged 2 commits into from
Feb 4, 2020
Merged

chore: delete import that was missed in #18274 #18334

merged 2 commits into from
Feb 4, 2020

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Jan 29, 2020
@mmalerba mmalerba requested a review from devversion January 29, 2020 20:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 29, 2020
crisbeto
crisbeto approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 29, 2020
@ngbot
Copy link

ngbot bot commented Jan 29, 2020

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing
    failure status "ci/circleci: tests_saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@devversion devversion removed the action: merge The PR is ready for merge by the caretaker label Jan 29, 2020
devversion
devversion approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmalerba CI seems to fail somehow. LGTM in general though. I think you might need to add the typing file to the legacy tsconfig. Otherwise it won't be loaded, since it's not referenced anywhere.

@mmalerba mmalerba requested a review from jelbourn as a code owner January 30, 2020 23:47
jelbourn
jelbourn approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jan 31, 2020
@mmalerba mmalerba merged commit 058198a into angular:master Feb 4, 2020
@mmalerba mmalerba deleted the zone-types branch February 4, 2020 18:41
mmalerba added a commit that referenced this pull request Feb 5, 2020
@mmalerba
chore: delete import that was missed in #18274 (#18334)
7794fe8 
* chore: delete import that was missed in #18274

* WIP: attempt to fix CI
mmalerba added a commit that referenced this pull request Feb 5, 2020
@mmalerba
Revert "chore: delete import that was missed in #18274 (#18334)"
a35639a 
This reverts commit 7794fe8.
yifange pushed a commit to yifange/components that referenced this pull request Feb 6, 2020
@mmalerba @yifange
chore: delete import that was missed in angular#18274 (angular#18334)
d1fb740 
* chore: delete import that was missed in angular#18274

* WIP: attempt to fix CI
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmalerba @jelbourn @crisbeto @devversion @googlebot