fix(mat-button-toggle): mat-button-toggle element should not have a focus indicator class. #18746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocus indicator class.
googlebot
added
the
cla: yes
crisbeto
added
lgtm
action: merge
mmalerba
added
G
mmalerba
pushed a commit
that referenced
this pull request
Apr 14, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class was mistakenly added onto both the
<mat-button-toggle>element and its child<button>. It should only be on the child<button>, because only the child is in the tab order. The only reason the parent<mat-button-toggle>has atabindex="-1"is so that it can work with things likecdkFocusInitial.