Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: dev-infra-private package not updating locally as expected #19196

Merged
merged 1 commit into from
Apr 28, 2020
Merged

build: dev-infra-private package not updating locally as expected #19196

merged 1 commit into from
Apr 28, 2020

Conversation

devversion
Copy link
Member

The dev-infra-private package sometimes is not updated
locally even if the integrity and SHA changed. This
seems to be because of a bug in yarn where the package
is restored from cache. A workaround seems to be using
the actual .git https URL.

See: yarnpkg/yarn#4722.

@devversion
build: dev-infra-private package not updated locally
ce6a39f 
The dev-infra-private package sometimes is not updated
locally even if the integrity and SHA changed. This
seems to be because of a bug in yarn where the package
is restored from cache. A workaround seems to be using
the actual `.git` https URL.

See: yarnpkg/yarn#4722.
@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Apr 28, 2020
@devversion devversion requested review from jelbourn and a team as code owners April 28, 2020 15:16
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 28, 2020
josephperrott
josephperrott approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I did not know about this bug, good catch!

jelbourn
jelbourn approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 28, 2020
@jelbourn jelbourn merged commit 76f1341 into angular:master Apr 28, 2020
jelbourn pushed a commit that referenced this pull request Apr 28, 2020
@devversion @jelbourn
build: dev-infra-private package not updated locally (#19196)
5d22b9f 
The dev-infra-private package sometimes is not updated
locally even if the integrity and SHA changed. This
seems to be because of a bug in yarn where the package
is restored from cache. A workaround seems to be using
the actual `.git` https URL.

See: yarnpkg/yarn#4722.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @josephperrott @googlebot