Skip to content

build: update to angular v10.0.0-next.6 #19287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2020
Merged

build: update to angular v10.0.0-next.6 #19287

merged 2 commits into from
May 8, 2020

Conversation

@devversion
Copy link
Member

@devversion devversion commented May 8, 2020

  • See individual commits.

devversion added 2 commits May 8, 2020 11:27
@devversion
build: update to angular v10.0.0-next.6
32cf3c5 
Updates to Angular v10.0.0-next.6 and applies modifications
as needed per latest APF 10 specification.
@devversion
build: update version placeholder for angular and tslib
a7f43aa 
Updates the version placeholder for Angular to allow for
v10.0.0-0 and v11.0.0-0.

Additionally, updates the tslib placeholder to match the
range allowed by the Angular framework packages.
@devversion devversion requested a review from a team May 8, 2020 09:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 8, 2020
@devversion devversion added merge safe target: major This PR is targeted for the next major release labels May 8, 2020
@devversion devversion added this to the 10.0.0 milestone May 8, 2020
crisbeto
crisbeto approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the lgtm label May 8, 2020
@devversion devversion added the P2 The issue is important to a large percentage of users, with a workaround label May 8, 2020
jelbourn
jelbourn approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label May 8, 2020
@devversion devversion added the merge: preserve commits When the PR is merged, a rebase and merge should be performed label May 8, 2020
@jelbourn jelbourn merged commit 449caec into angular:master May 8, 2020
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 8, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

@josephperrott josephperrott

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: preserve commits When the PR is merged, a rebase and merge should be performed P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@devversion @jelbourn @crisbeto @googlebot @josephperrott