Skip to content

Conversation

@crisbeto
Copy link
Member

Removes the APIs that were marked as deprecated for v10 in the checkbox module.

BREAKING CHANGES:

  • MAT_CHECKBOX_CLICK_ACTION has been removed. Specify the clickAction through MAT_CHECKBOX_DEFAULT_OPTIONS instead.
  • The clickAction parameter in the MatCheckbox constructor has been removed.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 17, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 17, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 17, 2020
@crisbeto crisbeto force-pushed the checkbox-v10-breaking-changes branch from f62fb44 to 0f7e9e8 Compare May 17, 2020 11:56
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 18, 2020
Removes the APIs that were marked as deprecated for v10 in the checkbox module.

BREAKING CHANGES:
* `MAT_CHECKBOX_CLICK_ACTION` has been removed. Specify the `clickAction` through `MAT_CHECKBOX_DEFAULT_OPTIONS` instead.
* The `clickAction` parameter in the `MatCheckbox` constructor has been removed.
@crisbeto crisbeto force-pushed the checkbox-v10-breaking-changes branch from 0f7e9e8 to c690c4b Compare May 23, 2020 10:08
@crisbeto
Copy link
Member Author

Closing since we couldn't get this resolved in time for RC. We can try to remove these APIs next time around.

@crisbeto crisbeto closed this May 26, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants