fix(cdk/platform): rtl scroll axis incorrectly determined in Safari macOS #19830
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acOS In Safari on macOS, the RTL scroll axis is determined incorrectly when scrollbars are set to `Always Display` as per macOS general system preferences. Our test element for the scroll axis sets a fixed height. This is resulting in a vertical scroll bar as the horizontal scroll bar for testing `scrollLeft` exceeds the scroll containers `1px` height. The vertical scroll bar then unveils a bug in Webkit where space is acquired on the right side for the scroll bar (while it's displayed on the left). This space causes our scroll axis detection to break as the horizontal `scrollLeft` unexpectedly expands to: `[-scrollWidth, 15px]` while usually `0px` is the right boundary. We fix this by simply ensuring that no vertical scroll bar is ever displayed. The vertical scrolling is not needed for determining the RTL horizontal scroll axis type. I've reported a bug upstream in Webkit: https://bugs.webkit.org/show_bug.cgi?id=213851. Fixes angular#14609.
devversion
added
P3
|
@googlebot Ping. |
googlebot
added
the
cla: yes
mmalerba
pushed a commit
that referenced
this pull request
Jul 11, 2020
…acOS (#19830) In Safari on macOS, the RTL scroll axis is determined incorrectly when scrollbars are set to `Always Display` as per macOS general system preferences. Our test element for the scroll axis sets a fixed height. This is resulting in a vertical scroll bar as the horizontal scroll bar for testing `scrollLeft` exceeds the scroll containers `1px` height. The vertical scroll bar then unveils a bug in Webkit where space is acquired on the right side for the scroll bar (while it's displayed on the left). This space causes our scroll axis detection to break as the horizontal `scrollLeft` unexpectedly expands to: `[-scrollWidth, 15px]` while usually `0px` is the right boundary. We fix this by simply ensuring that no vertical scroll bar is ever displayed. The vertical scrolling is not needed for determining the RTL horizontal scroll axis type. I've reported a bug upstream in Webkit: https://bugs.webkit.org/show_bug.cgi?id=213851. Fixes #14609.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Safari on macOS, the RTL scroll axis is determined incorrectly when
scrollbars are set to
Always Displayas per macOS general systempreferences. Our test element for the scroll axis sets a fixed height.
This is resulting in a vertical scroll bar as the horizontal scroll bar
for testing
scrollLeftexceeds the scroll containers1pxheight. Thevertical scroll bar then unveils a bug in Webkit where space is acquired
on the right side for the scroll bar (while it's displayed on the left).
This space causes our scroll axis detection to break as the horizontal
scrollLeftunexpectedly expands to:[-scrollWidth, 15px]whileusually
0pxis the right boundary. We fix this by simply ensuringthat no vertical scroll bar is ever displayed. The vertical scrolling
is not needed for determining the RTL horizontal scroll axis type.
I've reported a bug upstream in Webkit:
https://bugs.webkit.org/show_bug.cgi?id=213851.
I tested manually on Chrome 83.0.4103.116 Windows 10; macOS High Sierra Firefox 77; macOS High Sierra Safari 11.1, macOS Mojave Safari 12.1, macOS Catalina Safari 13.1, Windows 10 IE11.900.18362.0. Unfortunately there are no tests for this feature detection, nor would it be easy to write one for the particular scenario where a macOS setting is required.
Fixes #14609.