fix(cdk/drag-drop): pointer position calculation for SVG with viewBox #19863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in the Angular Material `drag-drop` component where the pointer position is incorrectly calculated for SVG with viewBox. This is because mouse coordinates retrieved using the screen coordinate system, but coordinates must be in SVG space, which is defined by the viewBox attribute.
googlebot
added
the
cla: yes
crisbeto
reviewed
Jul 5, 2020
crisbeto
added
lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Jul 8, 2020
…#19863) * fix(cdk/drag-drop): pointer position calculation for SVG with viewBox Fixes a bug in the Angular Material `drag-drop` component where the pointer position is incorrectly calculated for SVG with viewBox. This is because mouse coordinates retrieved using the screen coordinate system, but coordinates must be in SVG space, which is defined by the viewBox attribute. * save ownerSVGElement in a property
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the Angular Material
drag-dropcomponent where the pointer position is incorrectly calculated for SVG with viewBox. This is because mouse coordinates retrieved using the screen coordinate system, but coordinates must be in SVG space, which is defined by the viewBox attribute.Bug demo