test(mdc-button): add performance tests for mdc-button #20032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
wagnermaciel
force-pushed
the
mdc-button-benchmark
branch
from
7be4dbf to
21d0451
Compare
Contributor
Author
|
@andrewseguin I'm not sure why these tests are breaking. I'm running the same commands locally and they all build |
devversion
reviewed
Jul 17, 2020
devversion
reviewed
Jul 17, 2020
wagnermaciel
force-pushed
the
mdc-button-benchmark
branch
from
bed2ac1 to
f45cd25
Compare
devversion
approved these changes
Jul 20, 2020
devversion
added
lgtm
target: patch
This was referenced Jul 29, 2020
devversion
added
the
P2
mmalerba
pushed a commit
that referenced
this pull request
Aug 5, 2020
* test(mdc-button): add performance tests for mdc-button * fix(mdc-indigo-pink): add mat-core and mat-core-theme to indigo-pink * fixup! fix(mdc-indigo-pink): add mat-core and mat-core-theme to indigo-pink * fixup! test(mdc-button): add performance tests for mdc-button
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
mat-coreandmat-core-themetomdc-theming/prebuilt/indigo-pink.scss.Context
We noticed that the mdc-button's ripples were not working properly and thanks to @andrewseguin we were able to figure out that the mat-core and mat-core-theme mixins were not being included in material-experimental's indigo-pink.scss.