Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drag-drop): expose some missing injection tokens #20410

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

crisbeto
Copy link
Member

A couple of injection tokens weren't exposed from the drag-drop module. Normally these sorts of tokens would be internal, but the code from the drag-drop module is meant to be extended so we have to expose them to allow people to reach the same level of functionality.

Fixes #20406.

A couple of injection tokens weren't exposed from the `drag-drop` module. Normally these sorts of tokens would be internal, but the code from the `drag-drop` module is meant to be extended so we have to expose them to allow people to reach the same level of functionality.

Fixes angular#20406.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Aug 25, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 25, 2020
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Aug 25, 2020
@jelbourn jelbourn merged commit f795b9d into angular:master Aug 28, 2020
jelbourn pushed a commit that referenced this pull request Aug 28, 2020
A couple of injection tokens weren't exposed from the `drag-drop` module. Normally these sorts of tokens would be internal, but the code from the `drag-drop` module is meant to be extended so we have to expose them to allow people to reach the same level of functionality.

Fixes #20406.

(cherry picked from commit f795b9d)
annieyw pushed a commit to annieyw/components that referenced this pull request Aug 31, 2020
A couple of injection tokens weren't exposed from the `drag-drop` module. Normally these sorts of tokens would be internal, but the code from the `drag-drop` module is meant to be extended so we have to expose them to allow people to reach the same level of functionality.

Fixes angular#20406.
mmalerba pushed a commit that referenced this pull request Sep 2, 2020
A couple of injection tokens weren't exposed from the `drag-drop` module. Normally these sorts of tokens would be internal, but the code from the `drag-drop` module is meant to be extended so we have to expose them to allow people to reach the same level of functionality.

Fixes #20406.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(cdkDropList ): Module cdk/drag-drop has no exported member CDK_DROP_LIST
4 participants