refactor(overlay): remove deprecated APIs for v11 #20511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
overlay-v11-breaking-changes
branch
from
d48da68 to
cf891c3
Compare
jelbourn
added
the
merge: caretaker note
Member
|
Caretaker note: I remember that a nontrivial number of Google apps use |
crisbeto
force-pushed
the
overlay-v11-breaking-changes
branch
2 times, most recently
from
ceb42ab to
d7a4e38
Compare
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removing `ConnectedPositionStrategy` which has a separate PR (angular#17519), and `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height`, because they'll be trickier to land. BREAKING CHANGES: * The `OVERLAY_PROVIDERS` constant has been removed. Import `OverlayModule` and use the providers directly instead. * `_platform` parameter of the `OverlayContainer` constructor is now required. * `_platform` parameter of the `FullscreenOverlayContainer` constructor is now required. * `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef` constructor are now required. * `_location` and `_outsideClickDispatcher` parameters of the `Overlay` constructor are now required.
crisbeto
force-pushed
the
overlay-v11-breaking-changes
branch
from
d7a4e38 to
7f987c6
Compare
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Sep 24, 2020
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removing `ConnectedPositionStrategy` which has a separate PR (angular#17519), and `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height`, because they'll be trickier to land. BREAKING CHANGES: * The `OVERLAY_PROVIDERS` constant has been removed. Import `OverlayModule` and use the providers directly instead. * `_platform` parameter of the `OverlayContainer` constructor is now required. * `_platform` parameter of the `FullscreenOverlayContainer` constructor is now required. * `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef` constructor are now required. * `_location` and `_outsideClickDispatcher` parameters of the `Overlay` constructor are now required.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes most of the deprecated APIs for v11 under
cdk/overlay. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removingConnectedPositionStrategywhich has a separate PR (#17519), andGlobalPositionStrategy.widthandGlobalPositionStrategy.height, because they'll be trickier to land.BREAKING CHANGES:
OVERLAY_PROVIDERSconstant has been removed. ImportOverlayModuleand use the providers directly instead._platformparameter of theOverlayContainerconstructor is now required._platformparameter of theFullscreenOverlayContainerconstructor is now required._locationand_outsideClickDispatcherparameters of theOverlayRefconstructor are now required._locationand_outsideClickDispatcherparameters of theOverlayconstructor are now required.