feat(material/autocomplete): add the ability to auto-select the active option while navigating #20699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
autocomplete-auto-select
branch
2 times, most recently
from
b905ccb to
183b199
Compare
|
Overall looks good. Could we also add this option to |
Hi, he added it :) |
|
I somehow glossed right over that |
|
@crisbeto just needs a rebase |
crisbeto
force-pushed
the
autocomplete-auto-select
branch
from
183b199 to
ba613eb
Compare
crisbeto
force-pushed
the
autocomplete-auto-select
branch
from
ba613eb to
c8f2b3a
Compare
crisbeto
force-pushed
the
autocomplete-auto-select
branch
from
c8f2b3a to
7998f3a
Compare
crisbeto
force-pushed
the
autocomplete-auto-select
branch
from
7998f3a to
6d5c3b9
Compare
|
Hi @crisbeto , could you please resolve the merge conflict so I can run a fresh presubmit for this. I couldn't find the previous presubmit. This looks to me like it should be safe because the option we added is off by default 🤞 . |
|
Rebased. |
crisbeto
force-pushed
the
autocomplete-auto-select
branch
from
6d5c3b9 to
716fdec
Compare
crisbeto
force-pushed
the
autocomplete-auto-select
branch
from
716fdec to
3d6a061
Compare
andrewseguin
removed
the
cla: yes
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
autocomplete-auto-select
branch
from
3d6a061 to
22534f4
Compare
…e option while navigating Adds the `autoSelectActiveOption` input to `mat-autocomplete` which allows the consumer to opt into the behavior where the autocomplete will assign the active option value as the user is navigating through the list. The value is only propagated to the model once the panel is closed. There are a couple of UX differences when the new option is enabled: 1. If the user presses escape while there's a pending auto-selected option, the value is reverted to the last text they typed before they started navigating. 2. If the user clicks away, tabs away or presses enter while there's a pending option, it will be selected. The aforementioned UX differences are based on the Google search autocomplete and one of the examples from the W3C here: https://www.w3.org/TR/wai-aria-practices-1.1/examples/combobox/aria1.1pattern/listbox-combo.html
crisbeto
force-pushed
the
autocomplete-auto-select
branch
from
22534f4 to
124d442
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
autoSelectActiveOptioninput tomat-autocompletewhich allows the consumer to opt into the behavior where the autocomplete will assign the active option value as the user is navigating through the list. The value is only propagated to the model once the panel is closed.There are a couple of UX differences when the new option is enabled:
The aforementioned UX differences are based on the Google search autocomplete and one of the examples from the W3C here:
https://www.w3.org/TR/wai-aria-practices-1.1/examples/combobox/aria1.1pattern/listbox-combo.html