Skip to content

build: fix drag-drop demo #20743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2020
Merged

build: fix drag-drop demo #20743

merged 1 commit into from
Oct 8, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 7, 2020

I left in some invalid code in the drag-drop demo by accident while working on #20668 which is throwing an error now.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: minor This PR is targeted for the next minor release labels Oct 7, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 7, 2020
@crisbeto
build: fix drag-drop demo
c49d7b2 
I left in some invalid code in the `drag-drop` demo by accident while working on angular#20668 which is throwing an error now.
josephperrott
josephperrott approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Oct 7, 2020
@wagnermaciel wagnermaciel merged commit 650acbc into angular:master Oct 8, 2020
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 8, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

@josephperrott josephperrott

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @josephperrott @wagnermaciel