feat(material/chips): add test harnesses for selectable chips #20875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
jelbourn
reviewed
Oct 26, 2020
|
|
||
| /** Toggles the selected state of the given chip. */ | ||
| async toggle(): Promise<void> { | ||
| return (await this.host()).sendKeys(' '); |
There was a problem hiding this comment.
Does this assume the default value for separateKeyCodes?
There was a problem hiding this comment.
It doesn't. The only way to select a non-MDC chip is to press the spacebar on it.
Adds alternate test harnesses specifically for selectable chips and chips lists. Note that while these harnesses currently match the same elements as their non-selectable counterparts, they'll match different elements in the MDC chips module. This is a step towards consolidating the MDC and non-MDC harnesses for angular#20826.
crisbeto
force-pushed
the
20826/selectable-chip-harnesses
branch
from
812102a to
e43e65a
Compare
|
The feedback has been addressed. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds alternate test harnesses specifically for selectable chips and chips lists. Note that while these harnesses currently match the same elements as their non-selectable counterparts, they'll match different elements in the MDC chips module.
This is a step towards consolidating the MDC and non-MDC harnesses for #20826.