fix(google-maps): maintain subscriptions across event targets #20897
+194
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
mbehrlich
reviewed
Oct 27, 2020
src/google-maps/map-event-manager.ts
Outdated
| private _pending: {observable: Observable<any>, observer: Subscriber<any>}[] = []; | ||
| private _listeners: google.maps.MapsEventListener[] = []; | ||
| private _target: MapEventManagerTarget; | ||
| private _targets = new BehaviorSubject<MapEventManagerTarget>(undefined); |
There was a problem hiding this comment.
I think this member name is a little confusing. It implies there are several targets at the same time, when in fact there is still just a single target.
There was a problem hiding this comment.
Also, should the type be BehaviorSubject<MapEventManagerTarget|undefined> ?
There was a problem hiding this comment.
My thinking with making it plural was that it's a "stream of targets", but since we don't follow the $ suffix convention for observables, there wasn't a better way to indicate it. I'll rename it.
As for the | undefined, it's not necessary since MapEventManagerTarget includes undefined already.
This came up during the review of angular#20873. Currently the class that manages events for the Google Maps objects assumes that once a target is assigned, it'll either be maintained or eventually removed which means that the fix from angular#20873 will cause any existing event listeners to be dropped. These changes add some code which will preserve the listeners. Furthermore, I've added a dedicated testing setup for the `MapEventManager` since there's a fair bit of logic encapsulated in it and we've only been testing it by proxy through the various Google Maps components.
crisbeto
force-pushed
the
20873/google-maps-swap-target
branch
from
f099676 to
cc56523
Compare
wagnermaciel
pushed a commit
that referenced
this pull request
Oct 28, 2020
This came up during the review of #20873. Currently the class that manages events for the Google Maps objects assumes that once a target is assigned, it'll either be maintained or eventually removed which means that the fix from #20873 will cause any existing event listeners to be dropped. These changes add some code which will preserve the listeners. Furthermore, I've added a dedicated testing setup for the `MapEventManager` since there's a fair bit of logic encapsulated in it and we've only been testing it by proxy through the various Google Maps components. (cherry picked from commit cc503c4)
wagnermaciel
pushed a commit
that referenced
this pull request
Oct 28, 2020
This came up during the review of #20873. Currently the class that manages events for the Google Maps objects assumes that once a target is assigned, it'll either be maintained or eventually removed which means that the fix from #20873 will cause any existing event listeners to be dropped. These changes add some code which will preserve the listeners. Furthermore, I've added a dedicated testing setup for the `MapEventManager` since there's a fair bit of logic encapsulated in it and we've only been testing it by proxy through the various Google Maps components. (cherry picked from commit cc503c4)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up during the review of #20873. Currently the class that manages events for the Google Maps objects assumes that once a target is assigned, it'll either be maintained or eventually removed which means that the fix from #20873 will cause any existing event listeners to be dropped.
These changes add some code which will preserve the listeners.
Furthermore, I've added a dedicated testing setup for the
MapEventManagersince there's a fair bit of logic encapsulated in it and we've only been testing it by proxy through the various Google Maps components.