Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix characters remaining hint for textarea #2129

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

nickraphael
Copy link
Contributor

fix (input): Change name of local variable on md-textarea to fix hint binding of md-input.

#characterCountHintExample is the name given to both the md-input and md-textarea. This breaks the binding of the md-hint on the md-input. As the user types in the md-input field, the hint is not updated to show the remaining characters. However, when the user types in the md-textarea, the md-hint is updated on the textarea AND the input. The fix is simply to give each control a different #name.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 9, 2016
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 9, 2016
@mmalerba mmalerba merged commit 86123a3 into angular:master Dec 9, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants