fix(material/input): uncessary scroll bar on auto-resize textarea in some cases #21619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some cases It's common for apps to set `box-sizing: border-box` on all elements in the app which ends up causing unnecessary scroll bars on auto-resizing textareas. These changes explicitly set `box-sizing: content-box` to fix it. Note that ideally we'd do this at the `cdk/text-field` level since it is the one responsible for resizing the textarea, but we generally try to avoid changing the user's layout through the CDK. Fixes angular#21560.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
|
Caretaker note: this has the potential of causing screenshot diffs. If that is the case, we should re-evaluate the fix. |
|
Definitely willing to give the presubmit a try, but I feel like we've had a number of attempts to fix the scrollbars and the fixes always seem to fix the issue for half of people and cause it for the other half 😅 |
annieyw
pushed a commit
that referenced
this pull request
Feb 9, 2021
…some cases (#21619) It's common for apps to set `box-sizing: border-box` on all elements in the app which ends up causing unnecessary scroll bars on auto-resizing textareas. These changes explicitly set `box-sizing: content-box` to fix it. Note that ideally we'd do this at the `cdk/text-field` level since it is the one responsible for resizing the textarea, but we generally try to avoid changing the user's layout through the CDK. Fixes #21560. (cherry picked from commit 915791b)
annieyw
pushed a commit
that referenced
this pull request
Feb 9, 2021
…some cases (#21619) It's common for apps to set `box-sizing: border-box` on all elements in the app which ends up causing unnecessary scroll bars on auto-resizing textareas. These changes explicitly set `box-sizing: content-box` to fix it. Note that ideally we'd do this at the `cdk/text-field` level since it is the one responsible for resizing the textarea, but we generally try to avoid changing the user's layout through the CDK. Fixes #21560. (cherry picked from commit 915791b)
This was referenced Mar 11, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common for apps to set
box-sizing: border-boxon all elements in the app which ends up causing unnecessary scroll bars on auto-resizing textareas. These changes explicitly setbox-sizing: content-boxto fix it.Note that ideally we'd do this at the
cdk/text-fieldlevel since it is the one responsible for resizing the textarea, but we generally try to avoid changing the user's layout through the CDK.Fixes #21560.