Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/core): native-adapter uses first day of the week from locale data #21732

Closed
wants to merge 1 commit into from
Closed

fix(material/core): native-adapter uses first day of the week from locale data #21732

wants to merge 1 commit into from

Conversation

fetis
Copy link
Contributor

@fetis fetis commented Jan 28, 2021

Native adapter still uses hardcoded 0 value. I applied a fix mentioned here #8100

@fetis fetis requested a review from mmalerba as a code owner January 28, 2021 15:55
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 28, 2021
@fetis fetis changed the title fix: First day of the week from locale data fix(native-adapter): first day of the week from locale data Jan 28, 2021
@fetis fetis changed the title fix(native-adapter): first day of the week from locale data fix(material/core): native-adapter uses first day of the week from locale data Jan 28, 2021
@mmalerba
Copy link
Contributor

The change looks good once CI is passing

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Apr 22, 2022
@andrewseguin
Copy link
Contributor

I rebased but it looks like its failing some tests

@crisbeto
Copy link
Member

Done in #29802.

@crisbeto crisbeto closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fetis @mmalerba @andrewseguin @crisbeto @googlebot