Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-form-field): fix height for form field … #22089

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Mar 2, 2021

…with textarea

Before:
Screen Shot 2021-03-02 at 1 57 29 PM

After:
Screen Shot 2021-03-02 at 1 59 36 PM

Autosize <textarea> inputs and one line <textarea> inputs should default to the same height as <input> inputs

Line-height can sometimes cause containers to be slightly taller than their content so setting it to 0 prevents that.

@annieyw annieyw added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Mar 2, 2021
@annieyw annieyw requested a review from mmalerba March 2, 2021 22:00
@annieyw annieyw requested a review from devversion as a code owner March 2, 2021 22:00
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 2, 2021
@annieyw annieyw force-pushed the text-field-height branch from d72929e to 2ec6185 Compare March 2, 2021 22:01
@annieyw annieyw requested a review from jelbourn March 2, 2021 22:01
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 3, 2021
@annieyw annieyw merged commit a219a4a into angular:master Mar 9, 2021
annieyw added a commit that referenced this pull request Mar 9, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants