Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): add all providers to forRoot #2222

Merged
merged 2 commits into from
Dec 14, 2016
Merged

fix(a11y): add all providers to forRoot #2222

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58b6a54
fix(a11y): add all providers to forRoot
crisbeto Dec 14, 2016
95ef619
Remove redundant concat.
crisbeto Dec 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/core/a11y/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class A11yModule {
static forRoot(): ModuleWithProviders {
return {
ngModule: A11yModule,
providers: A11Y_PROVIDERS,
providers: PlatformModule.forRoot().providers.concat(A11Y_PROVIDERS),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do

providers: [
  PlatformModule.forRoot().providers, 
  A11Y_PROVIDERS,
],

Angular will flatten the list

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, TIL. It's changed.

};
}
}