Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-progress-spinner): set to display block #22618

Merged
merged 1 commit into from
May 4, 2021
Merged

fix(material-experimental/mdc-progress-spinner): set to display block #22618

merged 1 commit into from
May 4, 2021

Conversation

andrewseguin
Copy link
Contributor

This matches legacy styles and helps users migrate without adding this explicit style (especially when trying to use auto margin on the spinner).

Caretaker: This has been presubmitted with screenshot fixes in cl/371687399

@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels May 3, 2021
@andrewseguin andrewseguin requested review from crisbeto and annieyw May 3, 2021 15:04
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 3, 2021
crisbeto
crisbeto approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 3, 2021
@annieyw annieyw merged commit 1371a85 into angular:master May 4, 2021
annieyw pushed a commit that referenced this pull request May 4, 2021
@andrewseguin @annieyw
fix(material-experimental/mdc-progress-spinner): set to display block (…
638ed61 
…#22618)

(cherry picked from commit 1371a85)
annieyw pushed a commit that referenced this pull request May 4, 2021
@andrewseguin @annieyw
fix(material-experimental/mdc-progress-spinner): set to display block (…
5337421 
…#22618)

(cherry picked from commit 1371a85)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@annieyw annieyw Awaiting requested review from annieyw

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewseguin @crisbeto @annieyw