fix(material/core): reduce the number of module resolutions required for the legacy theming bundle #22687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
requested review from
andrewseguin,
devversion and
mmalerba
as code owners
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
theming-module-resolution
branch
from
d0bf2ce to
660aef4
Compare
jelbourn
approved these changes
May 13, 2021
jelbourn
added
action: merge
jelbourn
added
the
merge: caretaker note
devversion
approved these changes
May 13, 2021
crisbeto
force-pushed
the
theming-module-resolution
branch
2 times, most recently
from
071c2cd to
152fd96
Compare
…for the legacy theming bundle Currently the legacy `material/theming` bundle is set up to forward a few top-level `.import` files. The problem is that those files have been auto-generated to be backwards-compatible even for deep imports which means that they have a lot of overlapping `@forward` and `@import` statements. This results in a significant increase in build times for consumers still using the old bundle. These changes address the issue by introducing new shallower `*-legacy-index.scss` files which only export the APIs from the specific package and which in turn are re-exported through the top-level `material/theming` file. The change appears to cut the down the production build time on material.angular.io before the @use migration by more than 60%. Fixes angular#22676.
…quired for the legacy theming bundle
crisbeto
force-pushed
the
theming-module-resolution
branch
from
152fd96 to
0b48af9
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the legacy
material/themingbundle is set up to forward a few top-level.importfiles. The problem is that those files have been auto-generated to be backwards-compatible even for deep imports which means that they have a lot of overlapping@forwardand@importstatements. This results in a significant increase in build times for consumers still using the old bundle.These changes address the issue by introducing new shallower
*-legacy-index.scssfiles which only export the APIs from the specific package and which in turn are re-exported through the top-levelmaterial/themingfile. The change appears to cut the down the production build time on material.angular.io before the @use migration by more than 60%.Fixes #22676.