Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-tooltip): fix text alignment of multili… #22981

Merged
merged 7 commits into from
Jun 18, 2021

Conversation

wagnermaciel
Copy link
Contributor

…ne tooltips

  • Add the 'mdc-tooltip--multiline' class when a tooltip overflows
    to make the text align left (or right in rtl) instead of center

…ne tooltips

* Add the 'mdc-tooltip--multiline' class when a tooltip overflows
  to make the text align left (or right in rtl) instead of center
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2021
@wagnermaciel wagnermaciel marked this pull request as ready for review June 16, 2021 14:58
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test for the new code?

src/material/tooltip/tooltip.ts Outdated Show resolved Hide resolved
src/material/tooltip/tooltip.ts Outdated Show resolved Hide resolved
src/material/tooltip/tooltip.ts Outdated Show resolved Hide resolved
@wagnermaciel
Copy link
Contributor Author

Should we have a test for the new code?

Yes, it definitely should. I'll add one today 👍🏽

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 17, 2021
@mmalerba mmalerba merged commit 81cd26b into angular:master Jun 18, 2021
mmalerba pushed a commit that referenced this pull request Jun 18, 2021
#22981)

* fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

* Add the 'mdc-tooltip--multiline' class when a tooltip overflows
  to make the text align left (or right in rtl) instead of center

* fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

* fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

* fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

* test(material-experimental/mdc-tooltip): ensure the multiline class is set on tooltips with messages that overflow

* fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

* fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

(cherry picked from commit 81cd26b)
mmalerba pushed a commit that referenced this pull request Jun 18, 2021
#22981)

* fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

* Add the 'mdc-tooltip--multiline' class when a tooltip overflows
  to make the text align left (or right in rtl) instead of center

* fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

* fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

* fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

* test(material-experimental/mdc-tooltip): ensure the multiline class is set on tooltips with messages that overflow

* fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

* fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips

(cherry picked from commit 81cd26b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants