Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): correct structure for grid role #23022

Merged
merged 1 commit into from
Jun 22, 2021
Merged

fix(material/datepicker): correct structure for grid role #23022

merged 1 commit into from
Jun 22, 2021

Conversation

jelbourn
Copy link
Member

Previously, the grid in mat-datepicker was not strictly following the structure expected for the grid role. Additionally, this change adds an <abbr> element to the column headers such that VoiceOver can correctly read column headers.

Fixes #21357

@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) G This is is related to a Google internal issue area: material/datepicker labels Jun 18, 2021
@jelbourn jelbourn requested a review from mmalerba as a code owner June 18, 2021 21:47
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 18, 2021
@jelbourn jelbourn requested a review from crisbeto June 18, 2021 21:48
mmalerba
mmalerba approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jun 18, 2021
@jelbourn jelbourn force-pushed the datepicker-grid branch 2 times, most recently from 22387bf to 0457d09 Compare June 21, 2021 19:41
@jelbourn
fix(material/datepicker): correct structure for grid role
b3d7dbd 
Previously, the grid in mat-datepicker was not strictly following the structure expected for the grid role. Additionally, this change adds an `<abbr>` element to the column headers such that VoiceOver can correctly read column headers.

Fixes angular#21357
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Jun 22, 2021
@mmalerba mmalerba merged commit f0ddd54 into angular:master Jun 22, 2021
mmalerba pushed a commit that referenced this pull request Jun 22, 2021
@jelbourn @mmalerba
fix(material/datepicker): correct structure for grid role (#23022)
5b74a0d 
Previously, the grid in mat-datepicker was not strictly following the structure expected for the grid role. Additionally, this change adds an `<abbr>` element to the column headers such that VoiceOver can correctly read column headers.

Fixes #21357

(cherry picked from commit f0ddd54)
mmalerba pushed a commit that referenced this pull request Jun 22, 2021
@jelbourn @mmalerba
fix(material/datepicker): correct structure for grid role (#23022)
539e4cd 
Previously, the grid in mat-datepicker was not strictly following the structure expected for the grid role. Additionally, this change adds an `<abbr>` element to the column headers such that VoiceOver can correctly read column headers.

Fixes #21357

(cherry picked from commit f0ddd54)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dev054 dev054 dev054 left review comments

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/datepicker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(datepicker): <table> element inside of the datepicker should read out column labels for elements
4 participants
@jelbourn @crisbeto @mmalerba @dev054