Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/list): fix duplicate focus with chromevox on action-list items #23361

Merged
merged 1 commit into from
Jan 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/material/list/list-item.html
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<div class="mat-list-item-content">
<div class="mat-list-item-ripple" mat-ripple
<span class="mat-list-item-content">
zarend marked this conversation as resolved.
Show resolved Hide resolved
<span class="mat-list-item-ripple" mat-ripple
[matRippleTrigger]="_getHostElement()"
[matRippleDisabled]="_isRippleDisabled()">
</div>
</span>

<ng-content select="[mat-list-avatar], [mat-list-icon], [matListAvatar], [matListIcon]">
</ng-content>

<div class="mat-list-text"><ng-content select="[mat-line], [matLine]"></ng-content></div>
<span class="mat-list-text"><ng-content select="[mat-line], [matLine]"></ng-content></span>

<ng-content></ng-content>
</div>
</span>
1 change: 1 addition & 0 deletions src/material/list/list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ $item-inset-divider-offset: 72px;
}

.mat-list-item-ripple {
display: block;
@include layout-common.fill;

// Disable pointer events for the ripple container because the container will overlay the
Expand Down