Skip to content

Conversation

@devversion
Copy link
Member

Updates to the latest version of rules_sass which
provides the npm_sass_library rule allowing us to
drop the code we currently have to maintain on our own.

Note: I did not update Sass in the package.json as that is a version
update @crisbeto has a separate PR for.

Updates to the latest version of `rules_sass` which
provides the `npm_sass_library` rule allowing us to
drop the code we currently have to maintain on our own.
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Aug 30, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 30, 2021
@devversion devversion requested a review from a team August 30, 2021 18:37
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Aug 30, 2021
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 1b2dc9c into angular:master Aug 31, 2021
mmalerba pushed a commit that referenced this pull request Aug 31, 2021
Updates to the latest version of `rules_sass` which
provides the `npm_sass_library` rule allowing us to
drop the code we currently have to maintain on our own.

(cherry picked from commit 1b2dc9c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants