Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/icon): disable text selection #23730

Merged
merged 1 commit into from
Oct 24, 2021
Merged

fix(material/icon): disable text selection #23730

merged 1 commit into from
Oct 24, 2021

Conversation

crisbeto
Copy link
Member

Disables text selection inside mat-icon so that the text inside font icons can't be selected by accident.

@crisbeto
fix(material/icon): disable text selection
53b8b70 
Disables text selection inside `mat-icon` so that the text inside font icons can't be selected by accident.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Oct 11, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 11, 2021
jelbourn
jelbourn approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 13, 2021
@wagnermaciel wagnermaciel merged commit a931de5 into angular:master Oct 24, 2021
wagnermaciel pushed a commit that referenced this pull request Oct 24, 2021
@crisbeto @wagnermaciel
fix(material/icon): disable text selection (#23730)
d8c84d6 
Disables text selection inside `mat-icon` so that the text inside font icons can't be selected by accident.

(cherry picked from commit a931de5)
wagnermaciel pushed a commit that referenced this pull request Oct 24, 2021
@crisbeto @wagnermaciel
fix(material/icon): disable text selection (#23730)
114041f 
Disables text selection inside `mat-icon` so that the text inside font icons can't be selected by accident.

(cherry picked from commit a931de5)
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @wagnermaciel