Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(material/select): fix failing unit test #23870

Merged
merged 1 commit into from
Nov 2, 2021
Merged

test(material/select): fix failing unit test #23870

merged 1 commit into from
Nov 2, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 2, 2021

Fixes a unit test that started failing, because it tries to scroll the page down, but there isn't enough content for it to scroll.

@crisbeto
test(material/select): fix failing unit test
657969b 
Fixes a unit test that started failing, because it tries to scroll the page down, but there isn't enough content for it to scroll.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 2, 2021
@crisbeto crisbeto added merge safe P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Nov 2, 2021
@crisbeto crisbeto marked this pull request as ready for review November 2, 2021 09:01
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 2, 2021
This was referenced Nov 2, 2021
Merged
Merged
@jelbourn jelbourn merged commit 94aa7d3 into angular:master Nov 2, 2021
jelbourn pushed a commit that referenced this pull request Nov 2, 2021
@crisbeto @jelbourn
test(material/select): fix failing unit test (#23870)
de815cc 
Fixes a unit test that started failing, because it tries to scroll the page down, but there isn't enough content for it to scroll.

(cherry picked from commit 94aa7d3)
jelbourn pushed a commit that referenced this pull request Nov 2, 2021
@crisbeto @jelbourn
test(material/select): fix failing unit test (#23870)
b7457cf 
Fixes a unit test that started failing, because it tries to scroll the page down, but there isn't enough content for it to scroll.

(cherry picked from commit 94aa7d3)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @jelbourn