-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material-luxon-adapter): add option to set first day of week #24027
feat(material-luxon-adapter): add option to set first day of week #24027
Conversation
Add firstDayOfWeek option to be able to change first day of week behaviour through MAT_LUXON_DATE_ADAPTER_OPTIONS
Hmm, weird, the CI still decided not to run... |
I even created new fork and I saw that for the first time contributor you need to approve to CI to run. I do not know if there is needed some label to add for first time contributor? |
Those checks that need approval aren't the mandatory ones. Can you try the solution mentioned here? https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization- |
Honestly I do not know what should I do. I do not use CircleCI for any of my repos. I do not follow any projects there with my personal account. Maybe the checks will start after you approve this PR? |
I've approved it, but usually the CI runs as soon as you open the PR/push something to it. |
I tried to add one more commit and it looks like the CI started running? |
16be499
to
36fe393
Compare
@crisbeto All checks passed, only one missing is target label. Can you please add it? |
Is everything OK now? I still see:
|
Yes, now it's fine. |
@crisbeto Same issue here. Can this be "target: minor" as well? |
Yes, changed. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add firstDayOfWeek option to be able to change first day of week behaviour through MAT_LUXON_DATE_ADAPTER_OPTIONS