Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): crashing on chrome under certain conditions #2411

Merged
merged 5 commits into from
Jan 18, 2017
Merged

fix(tabs): crashing on chrome under certain conditions #2411

merged 5 commits into from
Jan 18, 2017

Commits on Dec 26, 2016

  1. fix(tabs): crashing on chrome under certain conditions 

    Prevents the tabs from either crashing Chrome (in Angular < 2.3) or throwing an animation error (in Angular >= 2.3). This was happening when the animations get triggered before the element is inserted into the DOM and thus doesn't have a computed `transform` value.

Fixes angular#2151.
    @crisbeto
    crisbeto committed Dec 26, 2016
    Configuration menu
    Copy the full SHA
    938dcca View commit details
    Browse the repository at this point in the history

  2. Fix IE errors.

    @crisbeto
    crisbeto committed Dec 26, 2016
    Configuration menu
    Copy the full SHA
    71ec389 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2016

  1. Add a TODO.

    @crisbeto
    crisbeto committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    b3fc47a View commit details
    Browse the repository at this point in the history

  2. Revert.

    @crisbeto
    crisbeto committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    6e30649 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2017

  1. Add TODO for removing the workaround.

    @crisbeto
    crisbeto committed Jan 10, 2017
    Configuration menu
    Copy the full SHA
    f8dc030 View commit details
    Browse the repository at this point in the history