refactor(multiple): remove PlatformModule usages #24366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn and
mmalerba
as code owners
devversion
approved these changes
Feb 6, 2022
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM, API goldens need to be updated.
The `PlatformModule` is a noop so we don't need to import it.
crisbeto
force-pushed
the
platform-module-cleanup
branch
from
050836d to
5df5d30
Compare
wagnermaciel
pushed a commit
that referenced
this pull request
Feb 11, 2022
The `PlatformModule` is a noop so we don't need to import it. (cherry picked from commit 68e7bd0)
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
The `PlatformModule` is a noop so we don't need to import it.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PlatformModuleis a noop so we don't need to import it.