Skip to content

Conversation

@devversion
Copy link
Member

The 16.14.0 NodeJS version is not provided in the Bazel NodeJS
rules and we cannot update since FW is blocked on the rules_nodejs
v5 update..

The `16.14.0` NodeJS version is not provided in the Bazel NodeJS
rules and we cannot update since FW is blocked on the rules_nodejs
v5 update..
@devversion devversion requested a review from a team as a code owner March 17, 2022 18:30
@devversion devversion requested a review from Splaktar March 17, 2022 18:30
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Mar 17, 2022
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I bump to "@bazel/ibazel": "0.16.2",, then this does fix it and I can run the dev-app build on my m1 mac.

@Splaktar
Copy link
Contributor

While I can run the build, it does end up failing far into the build:

Target //src/dev-app:devserver failed to build
Use --verbose_failures to see the command lines of failed build steps.
ERROR: /Users/splaktar/Git/angular/components/src/dev-app/BUILD.bazel:111:16 Splitting Javascript src/dev-app/main.ts src/components-examples/material/tree/index.ts src/components-examples/material/tooltip/index.ts src/components-examples/material/toolbar/index.ts src/components-examples/material/tabs/index.ts src/components-examples/material/table/index.ts src/components-examples/material/stepper/index.ts src/components-examples/material/sort/index.ts src/components-examples/material/snack-bar/index.ts src/components-examples/material/slider/index.ts src/components-examples/material/slide-toggle/index.ts src/components-examples/material/sidenav/index.ts src/components-examples/material/select/index.ts src/components-examples/material/radio/index.ts src/components-examples/material/progress-spinner/index.ts src/components-examples/material/progress-bar/index.ts src/components-examples/material/paginator/index.ts src/components-examples/material/menu/index.ts src/components-examples/material/list/index.ts src/components-examples/material/input/index.ts src/components-examples/material/icon/index.ts src/components-examples/material/grid-list/index.ts src/components-examples/material/form-field/index.ts src/components-examples/material/expansion/index.ts src/components-examples/material/divider/index.ts src/components-examples/material/dialog/index.ts src/components-examples/material/datepicker/index.ts src/components-examples/material/core/index.ts src/components-examples/material/chips/index.ts src/components-examples/material/checkbox/index.ts src/components-examples/material/card/index.ts src/components-examples/material/button-toggle/index.ts src/components-examples/material/button/index.ts src/components-examples/material/bottom-sheet/index.ts src/components-examples/material/badge/index.ts src/components-examples/material/autocomplete/index.ts src/components-examples/material-experimental/column-resize/index.ts src/components-examples/material-experimental/popover-edit/index.ts src/components-examples/material-experimental/mdc-card/index.ts src/components-examples/material-experimental/mdc-form-field/index.ts src/components-examples/material-experimental/selection/index.ts src/components-examples/cdk/tree/index.ts src/components-examples/cdk/text-field/index.ts src/components-examples/cdk/table/index.ts src/components-examples/cdk/stepper/index.ts src/components-examples/cdk/scrolling/index.ts src/components-examples/cdk/portal/index.ts src/components-examples/cdk/accordion/index.ts src/components-examples/cdk/platform/index.ts src/components-examples/cdk/drag-drop/index.ts src/components-examples/cdk/clipboard/index.ts src/components-examples/cdk/a11y/index.ts src/components-examples/cdk/layout/index.ts src/components-examples/cdk/overlay/index.ts src/components-examples/cdk-experimental/menu/index.ts src/components-examples/cdk-experimental/popover-edit/index.ts src/components-examples/cdk-experimental/selection/index.ts [esbuild] failed: Worker process did not return a WorkResponse:

---8<---8<--- Start of log, file at /private/var/tmp/_bazel_splaktar/280f06d55552a0d01f89f0955b5acd78/bazel-workers/worker-8-TypeScriptCompile.log ---8<---8<---
[link_node_modules.js] An error has been reported: [Error: ENOENT: no such file or directory, unlink 'node_modules'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'unlink',
  path: 'node_modules'
} Error: ENOENT: no such file or directory, unlink 'node_modules'
---8<---8<--- End of log ---8<---8<---
INFO: Elapsed time: 12.796s, Critical Path: 5.39s
INFO: 645 processes: 477 internal, 12 darwin-sandbox, 156 worker.

@Splaktar
Copy link
Contributor

It looks like that was a flake! Running yarn dev-app again build and served the dev-app successfully!

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Mar 18, 2022
@Splaktar
Copy link
Contributor

Confirming that I was also able to run the following on my m1Max

  • build-docs-content
  • lint
  • build-and-check-release-output
  • test-linker-aot
  • integration-tests
  • e2e

@wagnermaciel wagnermaciel merged commit 620e0cb into angular:master Mar 21, 2022
wagnermaciel pushed a commit that referenced this pull request Mar 21, 2022
The `16.14.0` NodeJS version is not provided in the Bazel NodeJS
rules and we cannot update since FW is blocked on the rules_nodejs
v5 update..

(cherry picked from commit 620e0cb)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
The `16.14.0` NodeJS version is not provided in the Bazel NodeJS
rules and we cannot update since FW is blocked on the rules_nodejs
v5 update..
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants