Skip to content

fix(material-experimental/mdc-form-field): ensure appearance is valid #24963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2022
Merged

fix(material-experimental/mdc-form-field): ensure appearance is valid #24963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f87d505
fix(material-experimental/mdc-form-field): ensure appearance is valid
mmalerba May 25, 2022
f9ef62c
fix(material-experimental/mdc-form-field): address feedback
mmalerba May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/material-experimental/mdc-form-field/form-field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,15 @@ export class MatFormField
}
set appearance(value: MatFormFieldAppearance) {
const oldValue = this._appearance;
this._appearance = value || this._defaults?.appearance || DEFAULT_APPEARANCE;
const newAppearance = value || this._defaults?.appearance || DEFAULT_APPEARANCE;
if (typeof ngDevMode === 'undefined' || ngDevMode) {
if (newAppearance !== 'fill' && newAppearance !== 'outline') {
throw new Error(
`MatFormField: Invalid appearance "${newAppearance}", valid values are "fill" or "outline".`,
);
}
}
this._appearance = newAppearance;
if (this._appearance === 'outline' && this._appearance !== oldValue) {
this._refreshOutlineNotchWidth();

Expand Down
2 changes: 1 addition & 1 deletion src/material/form-field/testing/shared.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ export function runHarnessTests(
<span matTextSuffix *ngIf="isMdc">suffix_text</span>
</mat-form-field>

<mat-form-field appearance="standard" color="warn" id="with-errors">
<mat-form-field [appearance]="isMdc ? 'fill' : 'standard'" color="warn" id="with-errors">
<span class="custom-control">Custom control harness</span>
<input matInput [formControl]="requiredControl">

Expand Down